rustyconover commented on PR #562: URL: https://github.com/apache/datasketches-cpp/pull/562#issuecomment-6525635628
Friendly ping: this is ready for review. The CI workflows haven't run on this PR yet because they're waiting for a maintainer to approve them. Could someone with write access approve them when they get a chance? Short version of the change: `density_sketch` didn't compile with any allocator other than `std::allocator`. The kernel only accepted `std::vector<T>`, and an unused `Allocator` member was always default-constructed. The new `density sketch: custom allocator` test covers updates in estimation mode, merge, a serialize/deserialize round trip, and checks that every byte is released. Happy to adjust anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
