leerho commented on PR #566: URL: https://github.com/apache/datasketches-cpp/pull/566#issuecomment-6693754556
Thanks, Hyeonho. The change looks right to me: it adds the same `sectionSize > MIN_K` stop that `ReqCompactor.ensureEnoughSections()` has in Java, and the new test fails without it (`k` = 14 gives a nominal capacity of 384 instead of 192). One small request: please restore the commented-out "for manual comparison with Java" test, or move its removal to a separate change, since it isn't related to this fix. We're finishing a bug-fix release and holding other PRs until it's out, so this will wait until then. It only affects a few small values of `k`, and the sketch is larger than designed rather than wrong, so it doesn't need to go into that release. It may need a small test adjustment at merge time, depending on what lands on master first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
