This is an automated email from the ASF dual-hosted git repository. leerho pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/datasketches-go.git
commit c9701e7d4c76952c615c3f2938f7d61bf126b561 Merge: 7c9421e 1aade78 Author: Lee Rhodes <[email protected]> AuthorDate: Sun Nov 8 12:41:20 2026 -0800 Merge pull request #163 from proost/test-cm-sketch-cross-language-compat test: count min sketch serialization test count/count_min_sketch.go | 20 ++++ count/count_min_sketch_serialization_test.go | 151 +++++++++++++++++++++++++++ count/count_min_sketch_test.go | 29 +++++ 3 files changed, 200 insertions(+) diff --cc count/count_min_sketch_test.go index 62cb543,ce84a3f..a0d68bc --- a/count/count_min_sketch_test.go +++ b/count/count_min_sketch_test.go @@@ -19,9 -19,9 +19,10 @@@ package coun import ( "bytes" + "encoding/binary" "testing" + "github.com/apache/datasketches-go/internal" "github.com/stretchr/testify/assert" ) @@@ -304,61 -320,10 +330,64 @@@ func Test_CountMinSketch(t *testing.T) assert.NoError(t, err) assert.Equal(t, c, d) assert.NotEqual(t, &c, d) + + _, err = NewCountMinSketchFromSlice(b.Bytes(), seed+1) + assert.Error(t, err) }) + + t.Run("CM deserialize truncated non-empty", func(t *testing.T) { + c, err := NewCountMinSketch(5, 64, seed) + assert.NoError(t, err) + for i := range uint64(10) { + assert.NoError(t, c.UpdateUint64(i, int64(10*i*i))) + } + var b bytes.Buffer + assert.NoError(t, c.Serialize(&b)) + data := b.Bytes() + + for trim := 1; trim <= 24; trim++ { + d, err := NewCountMinSketchFromSlice(data[:len(data)-trim], seed) + assert.ErrorContains(t, err, "bytes expected", "trim %d", trim) + assert.Nil(t, d) + } + }) + + t.Run("CM deserialize ignores trailing bytes", func(t *testing.T) { + c, err := NewCountMinSketch(5, 64, seed) + assert.NoError(t, err) + assert.NoError(t, c.UpdateUint64(1, 1)) + var b bytes.Buffer + assert.NoError(t, c.Serialize(&b)) + + data := append(b.Bytes(), make([]byte, 8)...) + d, err := NewCountMinSketchFromSlice(data, seed) + assert.NoError(t, err) + assert.Equal(t, c, d) + }) + + t.Run("CM deserialize rejects invalid dimensions", func(t *testing.T) { + c, err := NewCountMinSketch(2, 64, seed) + assert.NoError(t, err) + assert.NoError(t, c.UpdateUint64(1, 1)) + var b bytes.Buffer + assert.NoError(t, c.Serialize(&b)) + data := b.Bytes() + + // numBuckets * numHashes wraps to 0 in 32-bit arithmetic + overflow := bytes.Clone(data) + binary.LittleEndian.PutUint32(overflow[8:], 1<<29) + overflow[12] = 8 + d, err := NewCountMinSketchFromSlice(overflow, seed) + assert.ErrorContains(t, err, "these parameters generate a sketch that exceeds 2^30 elements") + assert.Nil(t, d) + + // numHashes >= 128 is negative as an int8 + negativeHashes := bytes.Clone(data) + negativeHashes[12] = 128 + d, err = NewCountMinSketchFromSlice(negativeHashes, seed) + assert.ErrorContains(t, err, "number of hashes must be non-negative") + assert.Nil(t, d) + }) } func BenchmarkCountMinSketch_Update(b *testing.B) { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
