leerho commented on issue #73: URL: https://github.com/apache/datasketches-postgresql/issues/73#issuecomment-6730449736
I have no objection if you wish to add KS to PostgreSQL. Keep it simple. I would implement the same three functions that we have in ds-cpp: 1. static double delta(const Sketch& sketch1, const Sketch& sketch2); 2. static double threshold(const Sketch& sketch1, const Sketch& sketch2, double p); 3. static bool test(const Sketch& sketch1, const Sketch& sketch2, double p); And in addition to normal functional testing I would perform characterization testing comparing PostgreSQL vs our C++ implementation to assess accuracy and speed performance. There are some refactoring changes coming to DS-CPP soon, so be aware that you may have to refactor your interface to C++ when that happens. Cheers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
