tisonkun opened a new issue, #584: URL: https://github.com/apache/datasketches-cpp/issues/584
`density_sketch` implements binary serialization (`density/include/density_sketch_impl.hpp`), and `apache/datasketches-rust` is adding `DensitySketch` support with compatible binary serialization (apache/datasketches-rust#62). However, `density/test/` currently has no `-DGENERATE=true` snapshot generator (`*_cpp.sk`), unlike the other sketches in this repository (for example, `tdigest/test/tdigest_serialize_for_java.cpp` and `kll/test/kll_sketch_serialize_for_java.cpp`). As a result, `apache/datasketches-tck` does not yet publish `density` snapshots under `serialization_test_data/cpp_generated_files/`. ### Proposal * Add a generator test under `density/test/` gated by `if (GENERATE)` in `density/test/CMakeLists.txt` that emits `density_float_*_cpp.sk` and `density_double_*_cpp.sk` snapshots (covering empty, exact-mode, and estimation-mode sketches). * Once merged, update `apache/datasketches-tck` (marking estimation-mode snapshots with randomized compaction as unstable) so downstream implementations such as `datasketches-rust` can consume shared TCK fixtures instead of maintaining inline byte snapshots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
