proost commented on code in PR #576:
URL: https://github.com/apache/datasketches-cpp/pull/576#discussion_r4572398419


##########
count/include/count_min_impl.hpp:
##########
@@ -460,6 +500,8 @@ void count_min_sketch<W,A>::check_header_validity(uint8_t 
preamble_longs, uint8_
   switch (sw) { // exhaustive list and description of all valid cases

Review Comment:
   Maybe corrupted input can pass this function. Because we just check sum. how 
about check each one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to