clee704 commented on PR #565: URL: https://github.com/apache/datasketches-cpp/pull/565#issuecomment-6963929365
> [@clee704](https://github.com/clee704) just checking in on this one. 5.3.1 is out now, so this PR is unblocked apart from the updatable SET checks in my review. The diff in my comment of Nov 12 has all three checks, in both `newSet` overloads, so it should only need to be applied and tested. > > We'd like to get this into the next minor release. If you're busy, we're happy to apply that diff to your branch ourselves (maintainer edits are enabled) and you can review it. Just let us know which you'd prefer. The question about the `noinline` attributes is still open too, but it doesn't block the merge. > > Thanks again for this work. Sorry for the delay. I'm working on it now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
