Repository: deltaspike Updated Branches: refs/heads/master 0d67f199e -> f47b9d305
DELTASPIKE-1165 Clean up old tests from the pre-java8 module. Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/f47b9d30 Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/f47b9d30 Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/f47b9d30 Branch: refs/heads/master Commit: f47b9d30528b6ab9574e078ff0ddff303135d144 Parents: 0d67f19 Author: John D. Ament <[email protected]> Authored: Mon Jun 6 21:41:23 2016 -0400 Committer: John D. Ament <[email protected]> Committed: Mon Jun 6 21:41:23 2016 -0400 ---------------------------------------------------------------------- .../apache/deltaspike/data/impl/QueryResultTest.java | 14 -------------- .../data/test/service/SimpleRepository.java | 3 --- 2 files changed, 17 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/deltaspike/blob/f47b9d30/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/impl/QueryResultTest.java ---------------------------------------------------------------------- diff --git a/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/impl/QueryResultTest.java b/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/impl/QueryResultTest.java index b40b710..a42025a 100644 --- a/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/impl/QueryResultTest.java +++ b/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/impl/QueryResultTest.java @@ -398,20 +398,6 @@ public class QueryResultTest extends TransactionalTestCase // no real check here, verifying query syntax passes. assertNotNull(result); } -// TODO Figure out a way to test this that doesn't require java 8 -// @Test -// public void shouldFindbyIdOptional() -// { -// Simple simple = builder.createSimple("bob"); -// -// java.util.Optional<Simple> optional = repo.findById(simple.getId()); -// assertTrue(optional.isPresent()); -// -// long nextId = simple.getId() + 1; -// -// repo.findById(nextId); -// assertFalse(optional.isPresent()); -// } @Before public void setup() http://git-wip-us.apache.org/repos/asf/deltaspike/blob/f47b9d30/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/test/service/SimpleRepository.java ---------------------------------------------------------------------- diff --git a/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/test/service/SimpleRepository.java b/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/test/service/SimpleRepository.java index 7d2870f..977736d 100755 --- a/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/test/service/SimpleRepository.java +++ b/deltaspike/modules/data/impl/src/test/java/org/apache/deltaspike/data/test/service/SimpleRepository.java @@ -121,9 +121,6 @@ public abstract class SimpleRepository extends AbstractEntityRepository<Simple, public abstract void removeByNameAndEnabled(String name, Boolean aTrue); -// TODO Figure out a way to test this that doesn't require java 8 -// public abstract java.util.Optional<Simple> findById(Long id); - @Override protected abstract EntityManager entityManager(); }
