DELTASPIKE-645 squid:S2131 - Primitives should not be boxed just for 'String' conversion
This closes #54 Project: http://git-wip-us.apache.org/repos/asf/deltaspike/repo Commit: http://git-wip-us.apache.org/repos/asf/deltaspike/commit/a56d0625 Tree: http://git-wip-us.apache.org/repos/asf/deltaspike/tree/a56d0625 Diff: http://git-wip-us.apache.org/repos/asf/deltaspike/diff/a56d0625 Branch: refs/heads/master Commit: a56d06256838c734e4b5f1269117a1095457df34 Parents: 2bc5406 Author: George Kankava <[email protected]> Authored: Tue Jun 28 21:25:30 2016 +0400 Committer: John D. Ament <[email protected]> Committed: Wed Jul 13 00:01:21 2016 -0400 ---------------------------------------------------------------------- .../org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java | 2 +- .../impl/scope/window/strategy/AbstractClientWindowStrategy.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/deltaspike/blob/a56d0625/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java ---------------------------------------------------------------------- diff --git a/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java b/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java index 00b0cb0..1ff1365 100644 --- a/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java +++ b/deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/jmx/DynamicMBeanWrapper.java @@ -159,7 +159,7 @@ public class DynamicMBeanWrapper extends NotificationBroadcasterSupport implemen } else { - methodName = "" + Character.toUpperCase(fieldName.charAt(0)); + methodName = Character.toString(Character.toUpperCase(fieldName.charAt(0))); } Method setter = null; http://git-wip-us.apache.org/repos/asf/deltaspike/blob/a56d0625/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/scope/window/strategy/AbstractClientWindowStrategy.java ---------------------------------------------------------------------- diff --git a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/scope/window/strategy/AbstractClientWindowStrategy.java b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/scope/window/strategy/AbstractClientWindowStrategy.java index 111f85b..4078e45 100644 --- a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/scope/window/strategy/AbstractClientWindowStrategy.java +++ b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/scope/window/strategy/AbstractClientWindowStrategy.java @@ -101,12 +101,12 @@ public abstract class AbstractClientWindowStrategy implements ClientWindow protected String generateNewWindowId() { //X TODO proper mechanism - return "" + (new Random()).nextInt() % 10000; + return Integer.toString((new Random()).nextInt() % 10000); } protected String generateNewRequestToken() { - return "" + ((int) Math.floor(Math.random() * 999)); + return Integer.toString((int) Math.floor(Math.random() * 999)); } protected boolean isPost(FacesContext facesContext)
