e2corporation commented on code in PR #1972:
URL: https://github.com/apache/incubator-devlake/pull/1972#discussion_r879491909
##########
config-ui/src/pages/configure/settings/jenkins.jsx:
##########
@@ -8,7 +25,7 @@ import '@/styles/integration.scss'
import '@/styles/connections.scss'
export default function JenkinsSettings (props) {
- const { connection, provider, isSaving, isSavingConnection, onSettingsChange
} = props
Review Comment:
As these settings are dynamically loaded, all of the Settings partials for
the `Providers` receive these common properties, though unused at the moment
they are destructured to show which properties are being injected and
available. In the future it's best to not allow the linter to automatically
remove these destructured props.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
