Startrekzky commented on issue #953: URL: https://github.com/apache/incubator-devlake/issues/953#issuecomment-1143622098
> I see #1771 and it's awesome! That's the detailed info for O > The table commit_files has already exists in domain layer the DDL is > > ``` > created_at datetime(3) null, > updated_at datetime(3) null, > _raw_data_params varchar(255) null, > _raw_data_table varchar(255) null, > _raw_data_id bigint unsigned null, > _raw_data_remark longtext null, > commit_sha varchar(40) not null, > file_path varchar(255) not null, > additions bigint null, > deletions bigint null, > primary key (commit_sha, file_path) > ``` > > and this contains changed-files path. So I think we just use GitHub-api and no need to use git-extractor. I think what we need to do is just reconstruct this table by adding a column `file_component` or by creating a new table with a map of `file_path` and `file_component`? This can be finished by parsing the path,I think. > > Is that right?@klesh 1. "So I think we just use GitHub-api and no need to use git-extractor." I think we should retrieve from [gitExtractor](https://github.com/apache/incubator-devlake/tree/main/plugins/refdiff), rather than from [Github API](https://docs.github.com/en/rest/commits/commits#get-a-commit) or Gitlab API due to API rate limit restrictions. 2. "I think what we need to do is just reconstruct this table by adding a column file_component or by creating a new table with a map of file_path and file_component? " I think this approach works, then we might have another table called 'file_components'. What do you think? @klesh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
