matrixji commented on code in PR #2084:
URL: https://github.com/apache/incubator-devlake/pull/2084#discussion_r889801569
##########
plugins/helper/default_task_context.go:
##########
@@ -188,14 +188,14 @@ func (c *DefaultTaskContext) SubTaskContext(subtask
string) (core.SubTaskContext
if run, ok := c.subtasks[subtask]; ok {
if run {
// now, create a sub task context if it didn't exist
- c.mu.Lock()
+ c.defaultExecContext.mu.Lock()
Review Comment:
It seems `structcheck`'s bug. It will report:
> plugins/helper/default_task_context.go:44:2: `mu` is unused (structcheck)
> mu sync.Mutex
> ^
Maybe we could disable `structcheck `, it only checks unused fields, but it
does not support embedded struct
ref: https://gitlab.com/opennota/check#known-limitations
> structcheck doesn't handle embedded structs yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
