klesh commented on issue #1914: URL: https://github.com/apache/incubator-devlake/issues/1914#issuecomment-1147142417
> @keon94 My guess for what @warren830 meant in step 3 is to verify the data correctness of the git extractor plugin after data collection. Historically, we have been comparing the number of records in the database after running the plugin with the number of records displayed on the data source's website. For example, you can check how many commits/tags are there in a project on GitHub against how many git extractor collected in the database. That sounds like an `e2e-test` with actual git repo and database involved and all. > @hezyin, okay so we'd want to do integration/manual testing for that. I'm just not sure how exactly we want to perform unit testing here as we're hitting a third party API. We'd have to mock the API calls to the repo instance if that's what we want. Do we have any instance of go-mock/mockery usage in our code-base that I can use as reference? At first glance, I couldn't find any. @warren830 please chime in when you get a chance. I have a PR with mockery setup https://github.com/apache/incubator-devlake/pull/2053, but for what we want to test against this plugin, I think `e2e-test` would be a better fit, that we don't need mockery at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
