hezyin commented on PR #2050: URL: https://github.com/apache/incubator-devlake/pull/2050#issuecomment-1154268112
@keon94 Hey Keon, thanks for addressing all the previous review comments. The PR looks good. Two last things: 1. Since `LibGit2` struct is just used for creating a `GitRepo` struct now, what do you think of renaming `LibGit2` struct to something like `GitRepoCreator` so it's more apparent to future developers? 2. Could you please compare the performance of the plugin before and after this PR for a relatively large git repository? I'm not sure how costly it is for libgit2 to iterate through the entire odb to get the counts, so better do a perf test to be sure. And when you do this comparison, it would be nice to verify that the old and new code creates the same amount of records in the database as well. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
