likyh commented on code in PR #2147:
URL: https://github.com/apache/incubator-devlake/pull/2147#discussion_r896558323


##########
plugins/gitlab/models/connection.go:
##########
@@ -17,11 +17,20 @@ limitations under the License.
 
 package models
 
+import (
+       "github.com/apache/incubator-devlake/plugins/helper"
+)
+
 // This object conforms to what the frontend currently sends.
 type GitlabConnection struct {
-       Endpoint string `mapstructure:"endpoint" validate:"required" 
env:"GITLAB_ENDPOINT" json:"endpoint"`
-       Auth     string `mapstructure:"auth" validate:"required" 
env:"GITLAB_AUTH"  json:"auth"`
-       Proxy    string `mapstructure:"proxy" env:"GITLAB_PROXY" json:"proxy"`
+       helper.RestConnection `mapstructure:",squash"`
+       helper.AccessToken    `mapstructure:",squash"`

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to