klesh commented on PR #2228: URL: https://github.com/apache/incubator-devlake/pull/2228#issuecomment-1158954731
> > @e2corporation Hi, I have talked to others, and here is the result: > > > > 1. `enable` means a blueprint is disabled or not, for `enable=false`, neither automation nor manual triggers are allowed. > > 2. as of `cronConfig` should be preserved in between Manual/Automated toggling, I agree, I will add another field `is_manual` > > > > * when `is_manual=true`, `cronConfig` is not required, however, it will be validated if provided. > > * when `is_manual=false`, `cronConfig` is required, and will be validated. > > Let me know your thought. > > I think in keeping with our camelCase conventions for API structs we should use `isManual` or just `manual`. `cronConfig` would always have a last known value or default to `hourly` for instance or whatever custom cron syntax the user defined. They are, check the screen-shots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
