warren830 commented on code in PR #2407:
URL: https://github.com/apache/incubator-devlake/pull/2407#discussion_r913452932
##########
plugins/github/tasks/commit_convertor.go:
##########
@@ -79,14 +78,14 @@ func ConvertCommits(taskCtx core.SubTaskContext) error {
Message: githubCommit.Message,
Additions: githubCommit.Additions,
Deletions: githubCommit.Deletions,
- AuthorId:
userDidGen.Generate(data.Options.ConnectionId, githubCommit.AuthorId),
+ AuthorId: githubCommit.AuthorEmail,
AuthorName: githubCommit.AuthorName,
AuthorEmail: githubCommit.AuthorEmail,
AuthoredDate: githubCommit.AuthoredDate,
CommitterName: githubCommit.CommitterName,
CommitterEmail: githubCommit.CommitterEmail,
CommittedDate: githubCommit.CommittedDate,
- CommitterId:
userDidGen.Generate(data.Options.ConnectionId, githubCommit.CommitterId),
+ CommitterId: githubCommit.CommitterEmail,
Review Comment:
> CommitterId and AuthorId use email?
Yes, the same to gitextractor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
