klesh commented on code in PR #2422:
URL: https://github.com/apache/incubator-devlake/pull/2422#discussion_r915489577
##########
helpers/e2ehelper/data_flow_tester_test.go:
##########
@@ -87,11 +87,10 @@ func TestGetTableMetaData(t *testing.T) {
var meta core.PluginMeta
dataflowTester := NewDataFlowTester(t, "test_dataflow", meta)
dataflowTester.FlushTabler(&TestModel{})
- t.Run("get_fields", func(t *testing.T) {
- fields := dataflowTester.getFields(&TestModel{}, func(column
gorm.ColumnType) bool {
- return true
- })
- assert.Equal(t, 9, len(fields))
+ t.Run("dal_get_columns", func(t *testing.T) {
Review Comment:
This test case should be moved to `dalgorm` module
##########
helpers/e2ehelper/data_flow_tester_test.go:
##########
@@ -118,8 +117,9 @@ func TestGetTableMetaData(t *testing.T) {
assert.Contains(t, columns, e)
}
})
- t.Run("get_pk_fields", func(t *testing.T) {
- fields := dataflowTester.getPkFields(&TestModel{})
+ t.Run("dal_get_pk_column_names", func(t *testing.T) {
Review Comment:
Same as above, this is testing Features of `dalgorm`, should be moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
