likyh commented on issue #1433: URL: https://github.com/apache/incubator-devlake/issues/1433#issuecomment-1180260770
> Using GraphQL can indeed make full collection much much faster. But we should also keep in mind that it might also reduces our ability to perform incremental collections. > > For example in GitHub's GraphQL schema the `issues` connection has a `since` filter parameter, so no problem here, but the `pull_requests` connection does not, and we can only filter PRs by state or label. > > So for incremental collection of PRs we have to fetch at least all opened PRs each time. In GitHub case, I guess that we still gain over the long run, it not like the typical project has thousands of opened PRs at a given time after all. But my point is that a query can be incremental only if GraphQL schema provide suitable filtering parameters for the corresponding connections. Yes. Issue support but PR not support. And maybe collecting all PRs by graphql can be faster than by restful because of fewer requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
