abeizn commented on code in PR #2492:
URL: https://github.com/apache/incubator-devlake/pull/2492#discussion_r920122933
##########
plugins/feishu/models/migrationscripts/archived/connection.go:
##########
@@ -23,12 +23,12 @@ import (
type FeishuConnection struct {
commonArchived.Model
- Name string `gorm:"type:varchar(100);uniqueIndex" json:"name"
validate:"required"`
- Endpoint string `mapstructure:"endpoint" env:"GITHUB_ENDPOINT"
validate:"required"`
- Proxy string `mapstructure:"proxy" env:"GITHUB_PROXY"`
- RateLimit int `comment:"api request rate limit per hour"`
- AppId string `mapstructure:"app_id" validate:"required"
json:"app_id"`
- SecretKey string `mapstructure:"secret_key" validate:"required"
json:"secret_key" encrypt:"yes"`
+ Name string `gorm:"type:varchar(100);uniqueIndex"
json:"name" validate:"required"`
+ Endpoint string `mapstructure:"endpoint" env:"GITHUB_ENDPOINT"
validate:"required"`
+ Proxy string `mapstructure:"proxy" env:"GITHUB_PROXY"`
+ RateLimitPerHour int `comment:"api request rate limit per hour"`
Review Comment:
> No, you can not change the archived file. It will break existing
magrations.
@likyh
How about we don't add the migration script this time, just so v0.12 doesn't
affect it, and we'll add it in a subsequent version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
