e2corporation commented on code in PR #2526:
URL: https://github.com/apache/incubator-devlake/pull/2526#discussion_r923301496
##########
config-ui/src/pages/blueprints/blueprint-detail.jsx:
##########
@@ -664,15 +664,12 @@ const BlueprintDetail = (props) => {
status: p.status,
statusLabel: TaskStatusLabels[p.status],
statusIcon: getTaskStatusIcon(p.status),
- startedAt: dayjs(p.beganAt).format('L LTS'),
- completedAt:
- p.status === 'TASK_RUNNING'
- ? ' - '
- : dayjs(p.finishedAt || p.updatedAt).format('L LTS'),
+ startedAt: p.beganAt ? dayjs(p.beganAt).format('L LTS') : '-',
+ completedAt: p.finishedAt ? dayjs(p.updatedAt).format('L LTS') : ' - ',
duration:
- p.status === 'TASK_RUNNING'
Review Comment:
Duration calc is different from a Running task versus a completed/failed
task. Why was the running check removed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
