klesh commented on code in PR #2504:
URL: https://github.com/apache/incubator-devlake/pull/2504#discussion_r926306466
##########
models/domainlayer/code/commit.go:
##########
@@ -45,13 +46,33 @@ func (Commit) TableName() string {
}
type CommitFile struct {
- common.NoPKModel
- CommitSha string `gorm:"primaryKey;type:varchar(40)"`
- FilePath string `gorm:"primaryKey;type:varchar(255)"`
+ domainlayer.DomainEntity
+ CommitSha string `gorm:"type:varchar(40)"`
+ FilePath string `gorm:"type:varchar(255)"`
Additions int
Deletions int
}
func (CommitFile) TableName() string {
return "commit_files"
}
+
+type Component struct {
Review Comment:
It would be better to move `Component` definition to an independent file
since it is not part of the `commit` structure, nor do they highly coupled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
