klesh commented on code in PR #2556:
URL: https://github.com/apache/incubator-devlake/pull/2556#discussion_r926327413
##########
plugins/gitlab/tasks/issue_extractor.go:
##########
@@ -186,17 +186,23 @@ func ExtractApiIssues(taskCtx core.SubTaskContext) error {
Extract: func(row *helper.RawData) ([]interface{}, error) {
body := &IssuesResponse{}
err := json.Unmarshal(row.Data, body)
+ fmt.Println(string(row.Data))
Review Comment:
Please remove this
##########
plugins/gitlab/tasks/issue_extractor.go:
##########
@@ -186,17 +186,23 @@ func ExtractApiIssues(taskCtx core.SubTaskContext) error {
Extract: func(row *helper.RawData) ([]interface{}, error) {
body := &IssuesResponse{}
err := json.Unmarshal(row.Data, body)
+ fmt.Println(string(row.Data))
if err != nil {
return nil, err
}
if body.ProjectId == 0 {
return nil, nil
}
- //If this is not Issue, ignore
- if body.IssueType != "ISSUE" && body.Type != "ISSUE" {
- return nil, nil
+
+ //If this have the info about Type or IssueType
+ if body.IssueType != "" || body.Type != "" {
Review Comment:
So, does it mean that it MUST be an `issue` if any of these fields is
missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
