e2corporation opened a new pull request, #2602:
URL: https://github.com/apache/incubator-devlake/pull/2602
### ⚠️ Config-UI / GitHub Integration / Personal Access Tokens & Connection
Testing
> WIP DO NOT MERGE
- [ ] **Check the Active/Focus'ed Element** before running GitHub's Personal
Access Token Sync.
- Exclude Connection Endpoint URL and Proxy URL fields when testing
connection
- [ ] Extract Connection Test Payload Parameters to a memoized/cache value
- Update `Connection Manager` Hook
- [ ] Test GitHub Connection & Personal Access Tokens
- [ ] Test GitHub Connection
- [ ] Test JIRA Connections
- [ ] Test Jenkins Connections
- [ ] Test GitLab Connections
- [ ] Code Linting & Cleanups
### Description
This PR applies optimizations to the **GitHub Connection Testing** workflow
with regard Personal Access Tokens. To prevent unwanted firing but still
achieve onChange testing with the token input fields, the test routine will
only execute if the currently focused elements are **NOT** Connection Endpoint
and Token. Additionally, the Connection Testing parameters
(`connectionTestPayload`) within the testConnection main routine provided by
the Connection Manager Hook have been extracted to a memoized cache call to
further reduce dependencies of the test connection callback and lessen
complexity.
Testing has also been done in Chrome Browser to ensure consistency with the
environment this bug was reported with.
### Does this close any open issues?
#2599
### Screenshots
<img width="1386" alt="Screen Shot 2022-07-26 at 12 17 06 AM"
src="https://user-images.githubusercontent.com/1742233/180921884-a3f5672b-8ef1-4cb2-9c9c-07f3cb3e74b0.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/1742233/180921884-a3f5672b-8ef1-4cb2-9c9c-07f3cb3e74b0.png"](https://user-images.githubusercontent.com/1742233/180921884-a3f5672b-8ef1-4cb2-9c9c-07f3cb3e74b0.png"){kind=link}