hezyin commented on code in PR #2600:
URL: https://github.com/apache/incubator-devlake/pull/2600#discussion_r930210348
##########
k8s-deploy.yaml:
##########
@@ -152,7 +152,7 @@ spec:
- name: config-ui
image: mericodev/config-ui:latest
ports:
- - containerPort: 4000
+ - containerPort: 30004
Review Comment:
Hi Aditya, based on [Kubernetes API
spec](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#ports),
the `containerPort` is primarily informational.
> Exposing a port here gives the system additional information about the
network connections a container uses, but is primarily informational. Not
specifying a port here DOES NOT prevent that port from being exposed.
So even if we completely remove line 155, it probably won't affect our
deployment. But its value should match with which port this container listens
at, which is 4000. You can verify this in `config-ui`'s docker file:
https://github.com/apache/incubator-devlake/blob/main/config-ui/Dockerfile#L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
