abeizn commented on code in PR #2769:
URL: https://github.com/apache/incubator-devlake/pull/2769#discussion_r949742684
##########
plugins/jenkins/impl/impl.go:
##########
@@ -65,15 +65,17 @@ func (plugin Jenkins) Description() string {
func (plugin Jenkins) SubTaskMetas() []core.SubTaskMeta {
return []core.SubTaskMeta{
- tasks.CollectApiJobsMeta,
- tasks.ExtractApiJobsMeta,
- tasks.CollectApiBuildsMeta,
- tasks.ExtractApiBuildsMeta,
- tasks.CollectApiStagesMeta,
- tasks.ExtractApiStagesMeta,
- tasks.EnrichApiBuildsMeta,
Review Comment:
Do you really want to annotate?
##########
plugins/jenkins/tasks/build_cicd_convertor.go:
##########
@@ -64,13 +43,9 @@ func ConvertBuildsToCICD(taskCtx core.SubTaskContext) error {
data := taskCtx.GetData().(*JenkinsTaskData)
clauses := []dal.Clause{
- dal.Select(`tjb.connection_id, tjb.duration, tjb.display_name,
tjb.estimated_duration, tjb.number,
- tjb._raw_data_remark, tjb._raw_data_id,
tjb._raw_data_table, tjb._raw_data_params,
- tjb.result, tjb.timestamp, tjb.start_time,
tjbr.commit_sha, tjb.type, tjb.class,
- tjb.triggered_by, tjb.building, tjbr.branch,
tjbr.repo_url, tjb.has_stages`),
- dal.From("_tool_jenkins_builds tjb"),
- dal.Join("left join _tool_jenkins_build_repos tjbr on
tjbr.build_name = tjb.display_name"),
- dal.Where("tjb.connection_id = ?", data.Options.ConnectionId),
+ dal.Select(`*`),
Review Comment:
Is it possible not to use * here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
