[incubator-devlake] branch main updated: fix: github since parameter does not work

[warren]

This is an automated email from the ASF dual-hosted git repository.

warren pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/main by this push:
     new 16f5834e fix: github since parameter does not work
16f5834e is described below

commit 16f5834e28a71c0724d7c3e289f18cfc587033a9
Author: abeizn <zikuan...@merico.dev>
AuthorDate: Tue Aug 23 12:17:06 2022 +0800

    fix: github since parameter does not work
---
 plugins/github/impl/impl.go | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/plugins/github/impl/impl.go b/plugins/github/impl/impl.go
index 92f88214..80116162 100644
--- a/plugins/github/impl/impl.go
+++ b/plugins/github/impl/impl.go
@@ -19,6 +19,7 @@ package impl
 
 import (
        "fmt"
+       "time"
 
        "github.com/apache/incubator-devlake/migration"
        "github.com/apache/incubator-devlake/plugins/core"
@@ -131,6 +132,8 @@ func (plugin Github) SubTaskMetas() []core.SubTaskMeta {
 }
 
 func (plugin Github) PrepareTaskData(taskCtx core.TaskContext, options 
map[string]interface{}) (interface{}, error) {
+       logger := taskCtx.GetLogger()
+       logger.Debug("%v", options)
        op, err := tasks.DecodeAndValidateTaskOptions(options)
        if err != nil {
                return nil, err
@@ -145,15 +148,28 @@ func (plugin Github) PrepareTaskData(taskCtx 
core.TaskContext, options map[strin
                return nil, fmt.Errorf("unable to get github connection by the 
given connection ID: %v", err)
        }
 
+       var since time.Time
+       if op.Since != "" {
+               since, err = time.Parse("2006-01-02T15:04:05Z", op.Since)
+               if err != nil {
+                       return nil, fmt.Errorf("invalid value for `since`: %w", 
err)
+               }
+       }
+
        apiClient, err := tasks.CreateApiClient(taskCtx, connection)
        if err != nil {
                return nil, fmt.Errorf("unable to get github API client 
instance: %v", err)
        }
-
-       return &tasks.GithubTaskData{
+       taskData := &tasks.GithubTaskData{
                Options:   op,
                ApiClient: apiClient,
-       }, nil
+       }
+
+       if !since.IsZero() {
+               taskData.Since = &since
+               logger.Debug("collect data updated since %s", since)
+       }
+       return taskData, nil
 }
 
 func (plugin Github) RootPkgPath() string {