[incubator-devlake] branch main updated: fix: do not pre-select active entity in create-mode (#2799)

[klesh]

This is an automated email from the ASF dual-hosted git repository.

klesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/main by this push:
     new 3ec95897 fix: do not pre-select active entity in create-mode (#2799)
3ec95897 is described below

commit 3ec958977b7d6ec34e8e2a3b59a80216e92d1d2a
Author: Julien Chinapen <julien.china...@merico.dev>
AuthorDate: Tue Aug 23 09:43:18 2022 -0400

    fix: do not pre-select active entity in create-mode (#2799)
    
    * fix: do not pre-select active entity in create-mode
    
    * feat: add tooltip and indicator to go back button
---
 .../create-workflow/DataTransformations.jsx        | 33 ++++++++++++++--------
 1 file changed, 22 insertions(+), 11 deletions(-)

diff --git 
a/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx 
b/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx
index a0cf65ae..197b2050 100644
--- 
a/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx
+++ 
b/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx
@@ -26,6 +26,9 @@ import {
   Elevation,
   Card,
   Colors,
+  Spinner,
+  Tooltip,
+  Position
 } from '@blueprintjs/core'
 import { Select } from '@blueprintjs/select'
 import { integrationsData } from '@/data/integrations'
@@ -116,18 +119,18 @@ const DataTransformations = (props) => {
   }, [entityList])
 
   useEffect(() => {
-    console.log('>>>>> PROJECT / BOARD ENTITY SELECTED!', activeEntity)
-    switch (activeEntity?.type) {
-      case 'board':
-        addBoardTransformation(activeEntity?.entity)
-        // addProjectTransformation(null)
-        break
-      case 'project':
-        addProjectTransformation(activeEntity?.entity)
-        // addBoardTransformation(null)
-        break
+    if (useDropdownSelector) {
+      console.log('>>>>> PROJECT / BOARD ENTITY SELECTED!', activeEntity)
+      switch (activeEntity?.type) {
+        case 'board':
+          addBoardTransformation(activeEntity?.entity)
+          break
+        case 'project':
+          addProjectTransformation(activeEntity?.entity)
+          break
+      }
     }
-  }, [activeEntity, addBoardTransformation, addProjectTransformation])
+  }, [activeEntity, addBoardTransformation, addProjectTransformation, 
useDropdownSelector])
 
   return (
     <div className='workflow-step workflow-step-add-transformation' 
data-step={activeStep?.id}>
@@ -380,6 +383,14 @@ const DataTransformations = (props) => {
                             onClick={() => onSave()}
                             // 
disabled={[Providers.GITLAB].includes(configuredConnection?.provider)}
                             style={{ marginLeft: '5px' }}
+                            icon={(
+                              <Tooltip
+                                position={Position.TOP}
+                                intent={Intent.PRIMARY}
+                                content={'Close Editor to Continue'}>
+                                  <Spinner size={12} />
+                              </Tooltip>
+                            )}
                           />
                         )}
                       </div>