mintsweet commented on code in PR #2928:
URL: https://github.com/apache/incubator-devlake/pull/2928#discussion_r963201139
##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -546,69 +493,45 @@ function useConnectionManager (
setUsername('')
setPassword('')
setToken('')
- setInitialTokenStore({
- 0: '',
- 1: '',
- 2: ''
- })
+ setInitialTokenStore(defaultTokenStore)
setProxy('')
- setRateLimit(0)
- }, [])
+ setRateLimitPerHour(0)
+ }, [defaultTokenStore])
useEffect(() => {
if (activeConnection && activeConnection.id !== null) {
- const connectionToken = activeConnection.auth || activeConnection.token
|| activeConnection.basicAuthEncoded
- setName(activeConnection.name)
- setEndpointUrl(activeConnection.endpoint)
- switch (provider.id) {
- case Providers.JENKINS:
- setUsername(activeConnection.username)
- setPassword(activeConnection.password)
- setProxy(activeConnection.Proxy || activeConnection.proxy)
- setRateLimit(activeConnection.rateLimitPerHour)
- break
- case Providers.GITLAB:
- setToken(activeConnection.basicAuthEncoded || activeConnection.token
|| activeConnection.auth)
- setProxy(activeConnection.Proxy || activeConnection.proxy)
- setRateLimit(activeConnection.rateLimitPerHour)
- break
- case Providers.GITHUB:
- setToken(connectionToken)
- setInitialTokenStore(connectionToken?.split(',')?.reduce((tS, cT,
id) => ({ ...tS, [id]: cT }), {}))
- setProxy(activeConnection.Proxy || activeConnection.proxy)
- setRateLimit(activeConnection.rateLimitPerHour)
- break
- case Providers.JIRA:
- // setToken(activeConnection.basicAuthEncoded ||
activeConnection.token)
- setUsername(activeConnection.username)
- setPassword(activeConnection.password)
- setProxy(activeConnection.Proxy || activeConnection.proxy)
- setRateLimit(activeConnection.rateLimitPerHour)
- break
- case Providers.TAPD:
- setUsername(activeConnection.username)
- setPassword(activeConnection.password)
- setProxy(activeConnection.Proxy || activeConnection.proxy)
- setRateLimit(activeConnection.rateLimitPerHour)
- break
- }
- ToastNotification.clear()
- // ToastNotification.show({ message: `Fetched settings for
${activeConnection.name}.`, intent: 'success', icon: 'small-tick' })
+ setName(activeConnection?.name)
+ setEndpointUrl(activeConnection?.endpoint)
+ setRateLimitPerHour(activeConnection?.rateLimitPerHour)
+ setProxy(activeConnection?.proxy)
+ setUsername(activeConnection?.username)
+ setPassword(activeConnection?.password)
+ setToken(activeConnection?.token)
+ setInitialTokenStore(activeConnection?.token
Review Comment:
Good code is easy to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
