klesh commented on code in PR #2955:
URL: https://github.com/apache/incubator-devlake/pull/2955#discussion_r963347593
##########
plugins/jira/e2e/issue_test.go:
##########
@@ -33,9 +33,28 @@ func TestIssueDataFlow(t *testing.T) {
taskData := &tasks.JiraTaskData{
Options: &tasks.JiraOptions{
- ConnectionId: 2,
- BoardId: 8,
- TransformationRules:
tasks.TransformationRules{StoryPointField: "customfield_10024"}},
+ ConnectionId: 2,
Review Comment:
the jira modification should not be included in this PR
##########
plugins/azure/e2e/build_definition_test.go:
##########
@@ -0,0 +1,71 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package e2e
+
+import (
+ "fmt"
+ "testing"
+
+ "github.com/apache/incubator-devlake/helpers/e2ehelper"
+ "github.com/apache/incubator-devlake/plugins/azure/impl"
+ "github.com/apache/incubator-devlake/plugins/azure/models"
+ "github.com/apache/incubator-devlake/plugins/azure/tasks"
+)
+
+func TestAzureBuildDefinitionDataFlow(t *testing.T) {
+ var github impl.Azure
+ dataflowTester := e2ehelper.NewDataFlowTester(t, "gitlab", github)
+
+ taskData := &tasks.AzureTaskData{
+ Options: &tasks.AzureOptions{
+ ConnectionId: 1,
+ Project: "test",
+ },
+ }
+
+ // import raw data table
+ // SELECT * FROM _raw_azure_api_build_definitions INTO OUTFILE
"/tmp/_raw_azure_api_build_definitions.csv" FIELDS TERMINATED BY ',' OPTIONALLY
ENCLOSED BY '"' LINES TERMINATED BY '\r\n';
+
dataflowTester.ImportCsvIntoRawTable("./raw_tables/_raw_azure_api_build_definitions.csv",
"_raw_azure_api_build_definitions")
+
+ // verify extraction
+ dataflowTester.FlushTabler(&models.AzureBuildDefinition{})
+ dataflowTester.Subtask(tasks.ExtractApiBuildDefinitionMeta, taskData)
+ dataflowTester.VerifyTable(
+ models.AzureBuildDefinition{},
+ fmt.Sprintf("./snapshot_tables/%s.csv",
models.AzureBuildDefinition{}.TableName()),
Review Comment:
Better to replace this line with a string literal, because the file name
would not be changed automatically when `TableName()` changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
