warren830 commented on code in PR #3076:
URL: https://github.com/apache/incubator-devlake/pull/3076#discussion_r972129811
##########
plugins/github/api/connection.go:
##########
@@ -90,18 +90,23 @@ func TestConnection(input *core.ApiResourceInput)
(*core.ApiResourceOutput, erro
results <- VerifyResult{err:
errors.Default.Wrap(err, fmt.Sprintf("verify token failed for #%v %s", j,
token))}
return
} else if githubUserOfToken.Login == "" {
- results <- VerifyResult{err:
errors.Default.Wrap(err, fmt.Sprintf("invalid token for #%v %s", j, token))}
+ results <- VerifyResult{err:
errors.Default.Wrap(errors.Unauthorized.New("invalid token"),
fmt.Sprintf("invalid token for #%v %s", j, token))}
+ return
+ } else {
+ results <- VerifyResult{login:
githubUserOfToken.Login}
return
}
- results <- VerifyResult{login: githubUserOfToken.Login}
}()
}
// collect verification results
logins := make([]string, 0)
msgs := make([]string, 0)
i := 0
+ fmt.Println("444444", len(results))
Review Comment:
> please delete it.
Hahaha, I was crashed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
