warren830 commented on code in PR #3190:
URL: https://github.com/apache/incubator-devlake/pull/3190#discussion_r979622899
##########
plugins/dora/tasks/cicd_task_env_enricher.go:
##########
@@ -70,7 +70,7 @@ func EnrichTasksEnv(taskCtx core.SubTaskContext) (err
errors.Error) {
} else {
cursor, err = db.Cursor(
dal.From(&devops.CICDTask{}),
- dal.Join("left join cicd_pipeline_commits cpr on
cpr.repo_id != '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),
+ dal.Join("left join cicd_pipeline_commits cpr on
cpr.repo_id = '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),
Review Comment:
I think we should filter cicd tasks by dataSource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
