e2corporation commented on PR #3107: URL: https://github.com/apache/incubator-devlake/pull/3107#issuecomment-1259949890
> > > > @henit-chobisa Additionally, the commit message structure for the last 2 commits does not conform to the current linter format (`fix:` `feat:` `refactor:` `chore:` etc) and is also causing the **Commit Message** CI Check to fail, can those commits messages be amended as well to fit the desired format? > > > > <img alt="Screen Shot 2022-09-26 at 2 16 26 PM" width="577" src="https://user-images.githubusercontent.com/1742233/192351052-09c46ece-ec84-42f9-a70a-b48656493980.png";> > > > > **Expected format to pass CI Check** > > > > > > > > * chore: removed makefile > > > > * chore: removed blueprint.go > > > > > > > > **or** > > > > > > > > * refactor: removed makefile > > > > * refactor: removed blueprint.go > > > > > > > > > I'm extremely sorry, I just forgot that I fix that now. > > > > > > @henit-chobisa No problem, it takes a bit of a adjustment getting used to the Linter on your first PR. Subsequent PRs should be much smoother once you've gone through the process. General workflow is once you are code complete and ready to remove Draft state, `npm run lint` should be performed on `@config-ui` to resolve Lint errors and ensure the formatting standards are applied. > > Sure Julien, I will take care that I won't create this much issues for reviewers and do everything perfectly. Thanks Henit, it's ok if issues occur, this is why we have the code review process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/1742233/192351052-09c46ece-ec84-42f9-a70a-b48656493980.png"](https://user-images.githubusercontent.com/1742233/192351052-09c46ece-ec84-42f9-a70a-b48656493980.png"){kind=link}