warren830 commented on code in PR #224:
URL:
https://github.com/apache/incubator-devlake-website/pull/224#discussion_r982047918
##########
docs/DataModels/DevLakeDomainLayerSchema.md:
##########
@@ -428,80 +429,80 @@ Events of pull requests.
### Domain 4 - CI/CD(WIP)
-#### jobs
-
-The CI/CD schedule, not a specific task.
-
-| **field** | **type** | **length** | **description** | **key** |
-| :-------- | :------- | :--------- | :-------------- | :------ |
-| `id` | varchar | 255 | Job id | PK |
-| `name` | varchar | 255 | Name of job | |
-
-#### builds
-
-A build is an execution of a job.
-
-| **field** | **type** | **length** | **description**
| **key** |
-| :------------- | :------- | :--------- |
:--------------------------------------------------------------- | :--------- |
-| `id` | varchar | 255 | Build id
| PK |
-| `job_id` | varchar | 255 | Id of the job this build belongs to
| FK_jobs.id |
-| `name` | varchar | 255 | Name of build
| |
-| `duration_sec` | bigint | | The duration of build in seconds
| |
-| `started_date` | datetime | 3 | Started time of the build
| |
-| `status` | varchar | 255 | The result of build. The values may
be 'success', 'failed', etc. | |
-| `commit_sha` | char | 40 | The specific commit being built on.
Nullable. | |
-
#### cicd_pipelines
A cicd_pipeline is a series of builds that have connections or a standalone
build.
-| **field** | **type** | **length** | **description**
| **key** |
-| :----------------- | :-------------- | :--------- |
:-------------------------------------------------------------- | :------ |
-| `id` | varchar | 255 | This key is generated
based on details from the original plugin | PK |
-| `created_at` | datetime | 3 |
| |
-| `updated_at` | datetime | 3 |
| |
-| `name` | varchar | 255 |
| |
-| `commit_sha` | varchar | 255 |
| |
-| `branch` | varchar | 255 |
| |
-| `repo` | varchar | 255 |
| |
-| `result` | varchar | 100 |
| |
-| `status` | varchar | 100 |
| |
-| `type` | varchar | 100 | to indicate this is CI or
CD | |
-| `duration_sec` | bigint unsigned | |
| |
-| `created_date` | datetime | 3 |
| |
-| `finished_date` | datetime | 3 |
| |
-
-#### cicd_pipeline_repos
-
-A map between cic_pipeline and repo info.
-
-| **field** | **type** | **length** | **description**
| **key** |
-| :----------- | :------- | :--------- |
:-------------------------------------------------------------- | :------ |
-| `commit_sha` | varchar | 255 |
| PK |
-| `branch` | varchar | 255 |
| |
-| `repo_url` | varchar | 255 |
| |
-| `id` | varchar | 255 | This key is generated based on details
from the original plugin | PK |
-| `created_at` | datetime | 3 |
| |
-| `updated_at` | datetime | 3 |
| |
-
+| **field** | **type** | **length** | **description**
| **key** |
+| :-------- | :-------- | :--------
|:----------------------------------------------------------------| :-------- |
+| `id` | varchar | 255) | This key is generated based on details from the
original plugin | PK |
+| `created_at` | datetime | 3) | Devlake
common.NoPKModel | |
Review Comment:
> why is there a `) ` after every length, such as `3)`, `255)`? Can we
remove them?
my bad, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
