e2corporation commented on PR #3303: URL: https://github.com/apache/incubator-devlake/pull/3303#issuecomment-1263816738
> > @henit-chobisa Also it's important to resolve any React `react-hooks/exhaustive-deps` dependency warnings. Please resolve _only_ the warning(s) associated with your files, leave any other warning regarding `DataTransformations`. > > It looks like one of the effects in `Nav.jsx` needs the dependencies added. > > <img alt="Screen Shot 2022-09-30 at 12 54 51 PM" width="1248" src="https://user-images.githubusercontent.com/1742233/193319881-9fb5819f-b5bb-4e16-9be4-ccb8a5a45db7.png";> > > Actually Julien, the suggested dependencies cannot be added to the array, as it will show adverse side effects, I have tried it before pushing. @henit-chobisa This is actually an indicator that the logic inside the Effect is flawed in some way causing a circular loop, and the logic flow should be altered and reworked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/1742233/193319881-9fb5819f-b5bb-4e16-9be4-ccb8a5a45db7.png"](https://user-images.githubusercontent.com/1742233/193319881-9fb5819f-b5bb-4e16-9be4-ccb8a5a45db7.png"){kind=link}