likyh opened a new issue, #3328:
URL: https://github.com/apache/incubator-devlake/issues/3328

   ## What and why to refactor
   Stop use `configuaredProject/configuaredBoard` in setting page's 
`onSettingsChange`.
   
   
https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/pages/configure/settings/github.jsx#L59
   
   Actually, setting page can only change its own project/board setting by 
`onSettingsChange`.
   
   So I'll defined `onSettingsChange` as `onSettingsChange(newSetting)` rather 
than `onSettingsChange(newSetting, projectId)` in 
https://github.com/apache/incubator-devlake/blob/7b0199a6d8557d4f18b73200d619a96d10df0163/config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx#L441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to