e2corporation commented on issue #3334: URL: https://github.com/apache/incubator-devlake/issues/3334#issuecomment-1273272049
@likyh I'm not saying that you can't optimize an Effect or fix a potential issue you have strongly identified, but the task of "delete all set functions in deps" seems a bit of a generalization. Are you trying to do this to the entire codebase or just this one `handleTransformationCancel` method ? If you are just refactoring `handleTransformationCancel` then go for it, If you are trying to impose this observation of no-setters in deps on all files that's a different issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
