[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #3371: add transformations hook to write all logic about it in one file.

Sun, 16 Oct 2022 17:04:28 -0700 


e2corporation commented on code in PR #3371:
URL: https://github.com/apache/incubator-devlake/pull/3371#discussion_r996530094


##########
config-ui/src/hooks/useDataScopesManager.jsx:
##########
@@ -661,16 +525,46 @@ function useDataScopesManager({
     ]
   )
 
+  const checkConfiguredProjectTransformationHasChanged = useCallback(
+    (item) => {
+      return checkTransformationHasChanged(
+        configuredConnection?.provider,
+        configuredConnection?.id,
+        item
+      )
+    },
+    [
+      configuredConnection?.provider,
+      configuredConnection?.id,
+      checkTransformationHasChanged
+    ]
+  )
+
+  const changeConfiguredProjectTransformationSettings = useCallback(

Review Comment:
   ```suggestion
     const changeEntityTransformation = useCallback(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to