warren830 commented on code in PR #3513:
URL: 
https://github.com/apache/incubator-devlake/pull/3513#discussion_r1001565672


##########
helpers/e2ehelper/data_flow_tester.go:
##########
@@ -419,17 +424,26 @@ func (t *DataFlowTester) VerifyTableWithOptions(dst 
schema.Tabler, opts TableOpt
        }
 
        targetFields := t.resolveTargetFields(dst, opts)
+       targetFieldMap := make(map[string]bool)
+       for _, v := range targetFields {
+               targetFieldMap[v] = true
+       }
        pkColumns, err := dal.GetPrimarykeyColumns(t.Dal, dst)
        if err != nil {
                panic(err)
        }
-
+       // will not check pk values as connection_id or board_id will be unique 
in snapshot tables

Review Comment:
   we have several pk columns, some will be diversity, some should be unique



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to