keon94 commented on code in PR #3532:
URL:
https://github.com/apache/incubator-devlake/pull/3532#discussion_r1002820076
##########
services/pipeline_runner.go:
##########
@@ -122,7 +122,10 @@ func runPipeline(pipelineId uint64) errors.Error {
// finished, update database
finishedAt := time.Now()
pipeline.FinishedAt = &finishedAt
- pipeline.SpentSeconds = int(finishedAt.Unix() - pipeline.BeganAt.Unix())
+ if pipeline.BeganAt != nil {
Review Comment:
I'm actually not finding any place in our code where BeganAt is ever set.
Has this always been nil then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
