keon94 commented on code in PR #3151:
URL: 
https://github.com/apache/incubator-devlake/pull/3151#discussion_r1013238379


##########
plugins/helper/api_rawdata.go:
##########
@@ -52,11 +52,12 @@ type RawDataSubTaskArgs struct {
 // RawDataSubTask is Common features for raw data sub-tasks
 type RawDataSubTask struct {
        args   *RawDataSubTaskArgs
-       table  string
-       params string
+       Table  string

Review Comment:
   I think moving this file to a new package is a good idea, but that'll end up 
touching a lot of different files . I think for now I'll just add Getter 
methods to this struct and make the fields private again to keep this PR simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to