keon94 commented on code in PR #3641: URL: https://github.com/apache/incubator-devlake/pull/3641#discussion_r1016098689
########## plugins/pagerduty/tasks/incidents_converter.go: ########## @@ -0,0 +1,159 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package tasks + +import ( + "fmt" + "github.com/apache/incubator-devlake/errors" + "github.com/apache/incubator-devlake/models/common" + "github.com/apache/incubator-devlake/models/domainlayer" + "github.com/apache/incubator-devlake/models/domainlayer/didgen" + "github.com/apache/incubator-devlake/models/domainlayer/ticket" + "github.com/apache/incubator-devlake/plugins/core" + "github.com/apache/incubator-devlake/plugins/core/dal" + "github.com/apache/incubator-devlake/plugins/helper" + "github.com/apache/incubator-devlake/plugins/pagerduty/models" + "reflect" + "time" +) + +var ConvertIncidentsMeta = core.SubTaskMeta{ + Name: "convertIncidents", + EntryPoint: ConvertIncidents, + EnabledByDefault: true, + Description: "Convert incidents into domain layer table issues", + DomainTypes: []string{core.DOMAIN_TYPE_TICKET}, +} + +type ( + // IncidentWithUser struct that represents the joined query result + IncidentWithUser struct { + common.NoPKModel + *models.Incident + *models.User + AssignedAt time.Time + } +) + +func ConvertIncidents(taskCtx core.SubTaskContext) errors.Error { + db := taskCtx.GetDal() + data := taskCtx.GetData().(*PagerDutyTaskData) + cursor, err := db.Cursor( + dal.Select("pi.*, pu.*, pa.assigned_at"), + dal.From("_tool_pagerduty_incident AS pi"), + dal.Join(`LEFT JOIN _tool_pagerduty_assignment AS pa ON pa.incident_number = pi.number`), + dal.Join(`LEFT JOIN _tool_pagerduty_user AS pu ON pa.user_id = pu.id`), + dal.Where("pi.connection_id = ?", data.Options.ConnectionId), + ) + if err != nil { + return err + } + defer cursor.Close() + + seenIncidents := map[int]*IncidentWithUser{} + + idGen := didgen.NewDomainIdGenerator(&models.Incident{}) + converter, err := helper.NewDataConverter(helper.DataConverterArgs{ + RawDataSubTaskArgs: helper.RawDataSubTaskArgs{ + Ctx: taskCtx, + Params: models.PagerDutyParams{ + ConnectionId: data.Options.ConnectionId, + Stream: models.IncidentStream, + }, + Table: RAW_INCIDENTS_TABLE, + }, + InputRowType: reflect.TypeOf(IncidentWithUser{}), + Input: cursor, + Convert: func(inputRow interface{}) ([]interface{}, errors.Error) { + combined := inputRow.(*IncidentWithUser) + incident := combined.Incident + user := combined.User + if seen, ok := seenIncidents[incident.Number]; ok { + if combined.AssignedAt.Before(seen.AssignedAt) { + // skip this one (it's an older assignee) + return nil, nil + } + } + status := getStatus(incident) + leadTime, resolutionDate := getTimes(incident) + domainIssue := &ticket.Issue{ + DomainEntity: domainlayer.DomainEntity{ + Id: idGen.Generate(data.Options.ConnectionId, incident.Number), + }, + Url: incident.Url, + IconURL: "", + IssueKey: fmt.Sprintf("%d", incident.Number), + Title: "", + Description: incident.Summary, + EpicKey: "", + Type: ticket.INCIDENT, + Status: status, + OriginalStatus: string(incident.Status), + StoryPoint: 0, + ResolutionDate: resolutionDate, + CreatedDate: &incident.CreatedDate, + UpdatedDate: &incident.UpdatedDate, + LeadTimeMinutes: leadTime, + ParentIssueId: "", + Priority: string(incident.Urgency), + OriginalEstimateMinutes: 0, + TimeSpentMinutes: 0, + TimeRemainingMinutes: 0, + CreatorId: "", + CreatorName: "", + AssigneeId: user.Id, + AssigneeName: user.Name, + Severity: "", + Component: "", + DeploymentId: incident.ServiceId, Review Comment: not sure if this is right. We're not creating any cicd tasks with pagerduty, so deployment-Id doesn't make sense in the usual sense... incident.ServiceId only refers to the pagerduty service that caused the incident, it's not a deployment of any sort. Let me know your thoughts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
