likyh commented on code in PR #3680:
URL:
https://github.com/apache/incubator-devlake/pull/3680#discussion_r1022347518
##########
runner/run_pipeline.go:
##########
@@ -90,18 +92,16 @@ func RunPipeline(
log.Error(err, "run tasks failed")
return errors.Convert(err)
}
- // Deprecated
+
// update finishedTasks
- finishedTasks += len(row)
err = db.Model(dbPipeline).Updates(map[string]interface{}{
- "finished_tasks": finishedTasks,
+ "finished_tasks": gorm.Expr("finished_tasks + ?",
len(row)),
Review Comment:
How do the finished_tasks count when rerunning only one task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
