likyh commented on code in PR #3797:
URL:
https://github.com/apache/incubator-devlake/pull/3797#discussion_r1030446169
##########
plugins/jira/api/scope.go:
##########
@@ -122,3 +149,16 @@ func extractParam(params map[string]string) (uint64,
uint64) {
boardId, _ := strconv.ParseUint(params["boardId"], 10, 64)
return connectionId, boardId
}
+
+func verifyBoard(board *models.JiraBoard) errors.Error {
+ if board.ConnectionId == 0 {
+ return errors.BadInput.New("invalid connectionId")
+ }
+ if board.BoardId == 0 {
+ return errors.BadInput.New("invalid boardId")
+ }
+ if board.ScopeId != strconv.FormatUint(board.BoardId, 10) {
Review Comment:
ScopeName is easy to set. But ScopeId maybe has some complex rules to
calculate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
