likyh commented on code in PR #3813:
URL:
https://github.com/apache/incubator-devlake/pull/3813#discussion_r1033173300
##########
plugins/jira/tasks/epic_collector.go:
##########
@@ -53,12 +53,7 @@ func CollectEpics(taskCtx core.SubTaskContext) errors.Error {
if err != nil {
return err
}
- since := data.Since
jql := "ORDER BY created ASC"
- if since != nil {
- // prepend a time range criteria if `since` was specified,
either by user or from database
- jql = fmt.Sprintf("updated >= '%s' %s",
since.Format("2006/01/02 15:04"), jql)
- }
collector, err := helper.NewApiCollector(helper.ApiCollectorArgs{
Review Comment:
Because now `data.startFrom` means `created>%s`. But issue created after
`data.startFrom` may use the epics created before `data.startFrom`.
In the old logic, Incremental is always false, So I think it is not correct
here.
And epic can collect 100 per page and it's not too big to collect
incrementally. So I delete them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
