klesh commented on code in PR #3858: URL: https://github.com/apache/incubator-devlake/pull/3858#discussion_r1040607217
########## models/migrationscripts/20221205_set_bp_plan_to_empty.go: ########## @@ -0,0 +1,61 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package migrationscripts Review Comment: I don't think we need this migration since we are going to regenerate the `plan` right before execution. I think it is find to leave them there ########## services/blueprint.go: ########## @@ -303,10 +291,20 @@ func ReloadBlueprints(c *cron.Cron) errors.Error { return nil } -func createPipelineByBlueprint(blueprint *models.Blueprint, name string, plan core.PipelinePlan) (*models.Pipeline, errors.Error) { +func createPipelineByBlueprint(blueprint *models.Blueprint) (*models.Pipeline, errors.Error) { + var plan core.PipelinePlan + var err errors.Error + if blueprint.Plan == nil { Review Comment: No! don't rely on the `plan` field, check the `mode` field please. ########## services/blueprint.go: ########## @@ -152,25 +150,16 @@ func validateBlueprintAndMakePlan(blueprint *models.Blueprint) errors.Error { if blueprint.Mode == models.BLUEPRINT_MODE_ADVANCED { plan := make(core.PipelinePlan, 0) err = errors.Convert(json.Unmarshal(blueprint.Plan, &plan)) - if err != nil { return errors.Default.Wrap(err, "invalid plan") } // tasks should not be empty if len(plan) == 0 || len(plan[0]) == 0 { return errors.Default.New("empty plan") } - } else if blueprint.Mode == models.BLUEPRINT_MODE_NORMAL { Review Comment: We still need to generate the plan on save to make sure the input is legitimate. Verification is more important than performance, not to mention it is not a bottleneck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
