likyh commented on code in PR #3861:
URL:
https://github.com/apache/incubator-devlake/pull/3861#discussion_r1040633271
##########
plugins/helper/api_collector.go:
##########
@@ -283,7 +283,7 @@ func (collector *ApiCollector)
fetchPagesUndetermined(reqData *RequestData) {
return nil
}
apiClient.NextTick(func() errors.Error {
- reqDataCopy.Pager.Skip +=
collector.args.PageSize
+ reqDataCopy.Pager.Skip +=
collector.args.PageSize * concurrency
Review Comment:
No. If there are 10 threads and pageSize is 10, the skips are 0, 10, 20,...
90. Their next skips should be 100, 110, 120, so add concurrency * pageSize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
