warren830 commented on code in PR #3847:
URL:
https://github.com/apache/incubator-devlake/pull/3847#discussion_r1040987103
##########
helpers/unithelper/dummy_logger.go:
##########
@@ -31,7 +31,21 @@ func DummyLogger() *mocks.Logger {
logger.On("Debug", mock.Anything, mock.Anything).Maybe()
logger.On("Info", mock.Anything, mock.Anything).Maybe()
logger.On("Warn", mock.Anything, mock.Anything).Maybe()
- logger.On("Error", mock.Anything, mock.Anything).Maybe()
+ logger.On("Error", mock.Anything, mock.Anything, mock.Anything).Maybe()
logger.On("Nested", mock.Anything).Return(logger).Maybe()
return logger
}
+
+// NewMockBasicRes FIXME ...
+func NewMockBasicRes(callback func(mockDal *mocks.Dal)) *mocks.BasicRes {
Review Comment:
why does this func in dummy_logger...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
