klesh opened a new pull request, #3956:
URL: https://github.com/apache/incubator-devlake/pull/3956

   ### Summary
   
   This is a prerequisite of #3709 
   
   1. Remove the unused/deprecated interfaces: `ConfigGetter` 
`InjectConfigGetter` and `InjectLogger`
   2. Add `GetConfigReader` to `BasicRes` for:
      - Remove `viper` coupling
      - Callers may utilize the typed methods(`GetBool` `GetInt`, etc.) which 
make our life easier 
      - We can create a new `BasicRes` instance from the existing one with ease
   
   ### Does this close any open issues?
   
   prerequisite of #3709 
   
   ### Screenshots
   
   I tested the GitHub pipeline, it looks alright.
   
![image](https://user-images.githubusercontent.com/61080/208049059-a9d02e4b-83dc-4b8c-bf73-3e898729bd84.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to