[incubator-devlake] branch release-v0.14 updated: fix: dbt log show failure, but it succeeded (#3969)

[abeizn]

This is an automated email from the ASF dual-hosted git repository.

abeizn pushed a commit to branch release-v0.14
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/release-v0.14 by this push:
     new e91507b60 fix: dbt log show failure, but it succeeded (#3969)
e91507b60 is described below

commit e91507b602c0ac13c72673a38e5eebf920072d30
Author: abeizn <zikuan...@merico.dev>
AuthorDate: Mon Dec 19 17:38:02 2022 +0800

    fix: dbt log show failure, but it succeeded (#3969)
    
    * fix: dbt log show failure, but it succeeded
    
    * fix: dbt log show failure, but it succeeded and add note
---
 plugins/dbt/tasks/convertor.go | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/plugins/dbt/tasks/convertor.go b/plugins/dbt/tasks/convertor.go
index b469d6244..ca5defa80 100644
--- a/plugins/dbt/tasks/convertor.go
+++ b/plugins/dbt/tasks/convertor.go
@@ -184,6 +184,13 @@ func DbtConverter(taskCtx core.SubTaskContext) 
errors.Error {
        if err != nil {
                return err
        }
+       // ProcessState contains information about an exited process, available 
after a call to Wait.
+       defer func() {
+               if !cmd.ProcessState.Success() {
+                       log.Error(nil, "dbt run task error, please check!!!")
+               }
+       }()
+
        // prevent zombie process
        defer cmd.Wait() //nolint
 
@@ -203,10 +210,6 @@ func DbtConverter(taskCtx core.SubTaskContext) 
errors.Error {
                return err
        }
 
-       if !cmd.ProcessState.Success() {
-               log.Error(nil, "dbt run task error, please check!!!")
-       }
-
        return nil
 }